Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #61
The real problem is that Webpack 5 isn't exporting most of its typings.
I opened a ticket that addresses this:
webpack/webpack#12869
Until then, I had to define the apply method as
apply(untypedResolver: Resolver | unknown): void
then cast it to this module'sResolver
.Once the webpack maintainers export their
Resolver
class definition, then that can be imported and directly replace all the references in this lib and it will work. (I did take the time to test that)I also added some Jest unit tests. It is probably worth adding the testing to the Husky scripts. During the testing, I found that the
logInfoToStdOut
was not working properly and all logs were going to standard, not error when defined.While I was in there, I updated the deps, adjusted the new
chalk
to work,I suggest moving from tslint to eslint as the former is depreciated.