Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Metdata" / "URL" model to hold required information in better format #2054

Closed
npalaska opened this issue Dec 18, 2020 · 1 comment

Comments

@npalaska
Copy link
Member

I think I had in mind a bit more generalization than this, but it's OK to start. This is really just the dashboard "URL", which I'd seen as one particular metadata key. While we can generalize later, I'd thought in terms of mapping the "URL"/saved-view into a PUT ("key": "dashboard-view", "id": "session-id", "value": "config/description") where Pbench didn't need to understand that the dashboard-view value is config/description.

But this is fine; we can go with making the dashboard saved-view the first-order implementation of metadata and grow it from there after we figure out exactly what we want in the schema, how we handle singletons vs lists, datatypes, etc.

Originally posted by @dbutenhof in #1937 (comment)

@portante
Copy link
Member

Long term we want to drop the URL storing model, see distributed-system-analysis/pbench-dashboard#133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants