Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nil pointer dereference if archive is not at ~/distri #54

Open
the-maldridge opened this issue Dec 22, 2019 · 1 comment
Open

nil pointer dereference if archive is not at ~/distri #54

the-maldridge opened this issue Dec 22, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@the-maldridge
Copy link

the-maldridge commented Dec 22, 2019

I'm trying to do a batch build of everything from scratch to get a feel for how the build process works, and right now it seems like distri does a hard coded check for its source tree at ~/distri. This is all good and well, but there really doesn't appear to be any error checking around this so a segfault occurs when the source archive is located anywhere else.

I'm happy to debug further, but I'm having trouble figuring out where certain values get initialized. I think that whatever is supposed to provide s.g.Nodes() on line 325 of batch.go isn't handling the bad directory correctly.

@stapelberg stapelberg added the bug Something isn't working label Dec 22, 2019
@stapelberg
Copy link
Member

With a current version of the distri executable, I can’t reproduce this:

When I run distri batch, it complains instead of panicing:

% distri batch  
2020/03/14 19:46:46 distriroot "/root/distri"
batch: open /root/distri/pkgs: no such file or directory

When I set DISTRIROOT, a batch build works (e.g. DISTRIROOT=$HOME/thedistri distri batch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants