Add slice method and slice notation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to implement https://github.com/tc39/proposal-slice-notation/blob/master/README.md instead |
|
Ok, we can merge it, when:
|
support array like values for slice
lahmatiy
reviewed
Aug 13, 2019
src/utils.js
Outdated
| @@ -24,9 +24,16 @@ function isRegExp(value) { | |||
| return toString.call(value) === '[object RegExp]'; | |||
| } | |||
|
|
|||
| function isArrayLike(value) { | |||
| return value && | |||
| hasOwnProperty.call(value, 0) && | |||
There was a problem hiding this comment.
So empty string or array is not array like?
lahmatiy
reviewed
Aug 13, 2019
src/parser.js
Outdated
| ['[ e : e : e ]', code`fn.slice(current, $2, $4, $6)`], | ||
| ['[ : e ]', code`fn.slice(current, 0, $3, 1)`], | ||
| ['[ : e : e ]', code`fn.slice(current, 0, $3, $5)`], | ||
| ['[ e : ]', code`fn.slice(current, $2, current.length, 1)`], |
There was a problem hiding this comment.
My suggestion is to pass undefined instead of current.length and convert undefined to current.length inside slice() when it's appropriate.
lahmatiy
reviewed
Aug 13, 2019
src/parser.js
Outdated
| @@ -255,7 +255,16 @@ const grammar = { | |||
| ['. SYMBOL ( arguments )', code`method.$2(/*@2*/current, $4)`], | |||
| ['.. SYMBOL', code`fn.recursive(/*@2*/current, "$2")`], | |||
| ['..( block )', code`fn.recursive(current, current => { $2 })`], | |||
| ['.[ block ]', code`fn.filter(current, current => { $2 })`] | |||
| ['.[ block ]', code`fn.filter(current, current => { $2 })`], | |||
| ['[ e : e ]', code`fn.slice(current, $2, $4, 1)`], | |||
There was a problem hiding this comment.
Let's try to collapse grammar, may be like that:
['[ sliceNotationComponent ]', code`fn.slice(current, 0, $2)`],
['[ sliceNotationComponent sliceNotationComponent ]', code`fn.slice(current, 0, $2, $3)`],
['[ e sliceNotationComponent ]', code`fn.slice(current, $2, $3)`],
['[ e sliceNotationComponent sliceNotationComponent ]', code`fn.slice(current, $2, $3, $4)`]
],
sliceNotationComponent: [
[':', code`undefined`],
[': e', code`$2`]
],
There was a problem hiding this comment.
One more try
queryRoot: [
...
['[ sliceNotation ]', code`fn.slice(current, $2)`]
],
relativePath: [
...
['query [ sliceNotation ]', code`fn.slice($1, $3)`]
],
sliceNotation: [
['sliceNotationComponent', code`0, $1`],
['sliceNotationComponent sliceNotationComponent', code`0, $1, $2`],
['e sliceNotationComponent', code`$1, $2`],
['e sliceNotationComponent sliceNotationComponent', code`$1, $2, $3`]
],
sliceNotationComponent: [
[':', code`undefined`],
[': e', code`$2`]
],sliceNotation can be changed to include [] into its syntaxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foo.sort().slice(0, 5)- get top 5 items