Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GuildMemberManager): Fix data type check for add() method #10338

Merged
merged 4 commits into from
Jun 29, 2024
Merged

fix(GuildMemberManager): Fix data type check for add() method #10338

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8538429
fix(GuildMemberManager): fix data type check
Jiralite Jun 8, 2024
37acb38
Merge branch 'main' into fix/add-empty
Jiralite Jun 8, 2024
146645a
Merge branch 'main' into fix/add-empty
Jiralite Jun 18, 2024
6b3f8c3
Merge branch 'main' into fix/add-empty
kodiakhq[bot] Jun 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/discord.js/src/managers/GuildMemberManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ class GuildMemberManager extends CachedManager {
resolvedOptions.roles = resolvedRoles;
}
const data = await this.client.rest.put(Routes.guildMember(this.guild.id, userId), { body: resolvedOptions });
// Data is an empty Uint8Array if the member is already part of the guild.
return data instanceof Uint8Array

// Data is an empty array buffer if the member is already part of the guild.
return data instanceof ArrayBuffer
? options.fetchWhenExisting === false
? null
: this.fetch(userId)
Expand Down
Loading