-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove unused Locale
typedef
#10191
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Shouldn't this be removed @Qjuh? |
Why should that be removed? As long as mainlib discord.js is JavaScript it should have JSDoc for intellisense purposes of non-ts users. |
Oh wait, now I see. Yes, that should be removed, because we reference the external discord.js/packages/discord.js/src/util/APITypes.js Lines 413 to 416 in a1a3a95
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't read the conversation first. Yes, the list should be removed, the typedef is already defined and links to discord-api-types's docs which is up-to-date.
502e77b
to
09dbc0b
Compare
I've updated the PR to remove the typedef instead as you suggested |
Please describe the changes this PR makes and why it should be merged:
Removes the unused typedef, as requested in the reviews
Status and versioning classification: