-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4096 image size and jpeg format that discord supports #4031
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the JSDocs accordingly as well
https://github.com/discordjs/discord.js/blob/master/src/util/Constants.js#L110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typings also need to be updated:
While you're at it, ImageExt
should be removed completely as it is a duplicate of AllowedImageFormat
. (changes in lines 2546 and 2551)
The size of
This could be Discord not documenting a new feature, or something they are experimenting with, that may go away again. |
as always in discord docs, it was not updated as many things in the docs, after i told my friend that 4096 is valid he decided to make a pr and it got almost instantly merged (see: #1501) |
As usual. |
Please describe the changes this PR makes and why it should be merged:
Discord also allows to open avatars/icons in ?size=4096 and discord.js was supporting upto 2048 so im opening this pr, also format .jpeg is a thing and it was not listed in d.js
Status
Semantic versioning classification: