fix(Typings): client message event should not emit PartialMessage #3983

monbrey · 2020-03-23T02:41:16Z

I can't think of a reason why the Client#message event would ever emit a PartialMessage.
If anyone else can, lets close this PR.

Status

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

This PR changes the library's interface (methods or parameters added)
- This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
This PR only includes non-code changes, like changes to documentation, README, etc.

typings/index.d.ts

Co-Authored-By: Jyguy <[email protected]>

fix(Typings): client message event should not emit PartialMessage

2d57405

Jyguy reviewed Mar 23, 2020

View reviewed changes

typings/index.d.ts Outdated Show resolved Hide resolved

iCrawl and others added 2 commits March 23, 2020 08:30

Update typings/index.d.ts

deb39ee

Co-Authored-By: Jyguy <[email protected]>

Merge branch 'master' into message-event-typings

1dd07de

iCrawl merged commit f2fdb93 into discordjs:master Mar 23, 2020

snyk-bot mentioned this pull request Apr 2, 2020

[Snyk] Upgrade discord.js from 12.0.0 to 12.1.1 junodevs/atmos#34

Merged

maybeanerd mentioned this pull request Apr 21, 2020

[Snyk] Upgrade discord.js from 12.0.2 to 12.1.1 maybeanerd/MagiBot#25

Merged

snyk-bot mentioned this pull request Apr 28, 2020

[Snyk] Upgrade discord.js from 12.0.2 to 12.2.0 WFCD/genesis#320

Merged

snyk-bot mentioned this pull request May 6, 2020

[Snyk] Upgrade discord.js from 12.0.2 to 12.1.1 MitchTalmadge/StudyBot#10

Closed

monbrey deleted the message-event-typings branch October 1, 2020 22:06

Provide feedback