feat: add sdk_version to HANDSHAKE message #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
approved these changes
Sep 26, 2024
matthova
reviewed
Sep 26, 2024
src/Constants.ts
Outdated
| @@ -36,3 +36,5 @@ export const Permissions = Object.freeze({ | |||
| CREATE_INSTANT_INVITE: BigFlagUtils.getFlag(0), | |||
| ADMINISTRATOR: BigFlagUtils.getFlag(3), | |||
| }); | |||
|
|
|||
| export const HANDSHAKE_SDK_VERSION_MINIUM_MOBILE_VERSION = '250.5'; | |||
There was a problem hiding this comment.
Dumb question, is it okay to use this string for both iOS and Android? I remember sometimes one had a <version>.0 and the other is just <version>
matthova
reviewed
Sep 26, 2024
| @@ -4,6 +4,7 @@ | |||
| import {Opcodes} from '../Discord'; | |||
| import {DiscordSDK, Events, Platform} from '../index'; | |||
| import {DISPATCH} from '../schema/common'; | |||
| import {version as sdkVersion} from '../../package.json'; | |||
matthova
reviewed
Sep 26, 2024
| @@ -53,8 +54,9 @@ function buildConfig(format) { | |||
| declaration: true, | |||
| outDir: outDir, | |||
| }), | |||
| json(), | |||
There was a problem hiding this comment.
is this required for retrieving the sdk's version?
src/Discord.ts
Outdated
Comment on lines
215
to
219
| } catch { | ||
| return null; | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Nit: Might be cool if we could return UNKNOWN or some other constant, so we could determine if the version is absent because of an error or because the version is too old to attempt to provide it
matthova
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.