Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extension Metadata]: small refactor & add load attribute #54

Open
1 task done
onerandomusername opened this issue Aug 18, 2021 · 0 comments · May be fixed by #69
Open
1 task done

[Extension Metadata]: small refactor & add load attribute #54

onerandomusername opened this issue Aug 18, 2021 · 0 comments · May be fixed by #69
Labels
good first issue Good for newcomers help wanted Extra attention is needed l: beginner p: normal Normal Priority s: approved The issue has received a maintainer's approval t: enhancement Changes or improvements to existing features t: feature Relating to the functionality of the application.

Comments

@onerandomusername
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues and there is no existing issue.

What is the feature?

Overview

While our extension loading system is able to handle multiple different cases, we'd like to add support to the metadata to be able to set files to not load when the bot is loaded, and load them at a later time.
We'd also like to have extensions and plugins which are walked, deemed valid, but not loaded. This allows us to have them in the system, but not have them loaded at the time.

Implementation

The majority of the walking takes place in modmail/utils/extensions.py, but a bit of it also takes place in modmail/utils/plugins.py

Both of these metadata loaders should be refactored to load metadata into a dict, in order to make easier to expand over time. Anywhere that these wailking methods are used will need to be updated to use the dict, and where EXTENSIONS or PLUGINS global variables are used.

Would you like to implement this yourself?

No, someone else can implement it

@onerandomusername onerandomusername added help wanted Extra attention is needed good first issue Good for newcomers a: bot l: beginner p: normal Normal Priority s: approved The issue has received a maintainer's approval t: enhancement Changes or improvements to existing features t: feature Relating to the functionality of the application. labels Aug 18, 2021
@onerandomusername onerandomusername linked a pull request Sep 19, 2021 that will close this issue
@onerandomusername onerandomusername linked a pull request Sep 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed l: beginner p: normal Normal Priority s: approved The issue has received a maintainer's approval t: enhancement Changes or improvements to existing features t: feature Relating to the functionality of the application.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants