Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatic bumping of version with poetry #42

Open
1 task done
onerandomusername opened this issue Aug 3, 2021 · 2 comments
Open
1 task done

feat: Automatic bumping of version with poetry #42

onerandomusername opened this issue Aug 3, 2021 · 2 comments
Assignees
Labels
a: tools Development related to our toolchain (Docker, poetry, flake8) l: beginner p: normal Normal Priority s: approved The issue has received a maintainer's approval s: deferred Will be done at a later time t: enhancement Changes or improvements to existing features

Comments

@onerandomusername
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues and there is no existing issue.

What is the feature?

Configure a workflow or precommit check or something.

Some way to ensure that with all pull request merges, we follow semantic versioning.

Would you like to implement this yourself?

Yes, I'd like to implement this

@onerandomusername onerandomusername added help wanted Extra attention is needed a: CI Continuous Integration and Continuous Deployment l: beginner p: normal Normal Priority s: approved The issue has received a maintainer's approval s: deferred Will be done at a later time t: enhancement Changes or improvements to existing features t: feature Relating to the functionality of the application. a: tools Development related to our toolchain (Docker, poetry, flake8) labels Aug 3, 2021
@onerandomusername onerandomusername self-assigned this Aug 3, 2021
@Shivansh-007
Copy link
Member

Tiangolo, the author of the lovely framework FastAPI has done one more lovely thing for your lovely issue.

He introduced a poetry plugin a while ago, which does exactly what you wish to have. It can read the version from an __init__.py file:

# __init__.py

__version__ = "0.1.0"

or from a git tag, set with a GitHub release or with:

$ git tag 0.1.0

@Shivansh-007 Shivansh-007 removed help wanted Extra attention is needed a: CI Continuous Integration and Continuous Deployment t: feature Relating to the functionality of the application. labels Aug 3, 2021
@onerandomusername
Copy link
Member Author

onerandomusername commented Aug 3, 2021

That isn't exactly what I'm looking for. That looks for a __version__ variable in the package and uses that for the package version, rather than what is in the pyproject.toml file. Meanwhile, poetry version will bump the version in the pyproject.toml file,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tools Development related to our toolchain (Docker, poetry, flake8) l: beginner p: normal Normal Priority s: approved The issue has received a maintainer's approval s: deferred Will be done at a later time t: enhancement Changes or improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants