Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverts if object key does not change wouldn't work #8

Open
discentem opened this issue Jun 22, 2022 · 3 comments
Open

reverts if object key does not change wouldn't work #8

discentem opened this issue Jun 22, 2022 · 3 comments

Comments

@discentem
Copy link
Owner

Right now objects are stored like pantri/repo/go1.18.3.darwin-arm64.pkg but this is might not be unique enough as we are just relying on filename. We should consider storing stuff like pantri/path/to/object/HASH_GOES_HERE/object

@natewalck
Copy link
Collaborator

I'm not sure if this is truly necessary.

With git, you have multiple versions of the same file with the same name, in the same path.

With binary storage, you generally don't have this issue, mainly due to the fact that it is impossible to have two files of the same name in the same directory. (Plus, I'd categorize that as a user error).

I think the paradigm of having Firefox.dmg be multiple possible versions of Firefox is one that we don't really want to promote. Firefox-101.0.1.dmg should be preferred and suggested.

Let's keep it simple until we find a specific case where we need to get fancy.

@discentem
Copy link
Owner Author

Definitely appreciate the reply/explanation and agreed. I think I was over thinking this. Closing out until we find some edge case that would warrant this.

@discentem discentem reopened this May 13, 2023
@discentem
Copy link
Owner Author

discentem commented May 13, 2023

@natewalck @radsec and I were discussing this a lot recently in Slack. We're split on if this is necessary but we all agree that if we implement it should NOT be with a hash in the path as this would break Munki and other known use cases for Cavorite.

One suggested solution for s3 by @radsec was object versioning. We could add a field to .cfile to track this.

@discentem discentem changed the title consider including hash in path of pantri objects reverts if object key does not change wouldn't work May 13, 2023
@renovate renovate bot mentioned this issue Aug 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants