New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move config validation to cli package instead of in specific store implementations #113

Open

discentem opened this issue May 31, 2023 · 0 comments

Owner

discentem commented May 31, 2023

#111 still does config checking within the store. (Specifically, checking for the metadata extension config to exist)

If a config is required for cavorite to run, we should be checking it and bailing (or set a default) in the code that is reading the config. This should live here: https://github.com/discentem/cavorite/blob/main/internal/cli/init.go#L72

The config code should own the config validation, if that makes sense.

discentem mentioned this issue

Lots of code in different stores can be consolidated #106

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment