Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to jsonpath-ng #190

Merged
merged 2 commits into from
Jun 30, 2021
Merged

switch to jsonpath-ng #190

merged 2 commits into from
Jun 30, 2021

Conversation

snopoke
Copy link
Contributor

@snopoke snopoke commented Jun 25, 2021

PR on top of #189

jsonpath-ng is a fork of jsonpath-rw with some additional features and a number of bugfixes. Since jsonpath-rw is not currently maintained it makes sense to move to jsonpath-ng. jsonpath-ng is also used in HQ.

Copy link
Member

@czue czue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good for whenever you have a migration plan. are there not any other tests that need to change?

@snopoke
Copy link
Contributor Author

snopoke commented Jun 25, 2021

code looks good for whenever you have a migration plan. are there not any other tests that need to change?

I don't think any migration is necessary. This is basically a drop in replacement. Installing a new version of commcare-export will automatically install jsonpath-ng.

Base automatically changed from sk/value-or-root to master June 25, 2021 12:34
@snopoke snopoke merged commit 0538bad into master Jun 30, 2021
@snopoke snopoke deleted the sk/jsonpath-ng branch June 30, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants