remove additional auto-id field #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related weird functionality in jsonpath-rw: kennknowles/python-jsonpath-rw#96 |
|
Closing this for now since merging it will potentially break existing exports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this 'hack' become unecessary after this change e1eae02417dbaeaf34c407bef0afe9600a21e24a.
Unfortunately this change may break existing usages of the DET if the 'auto_id' functionality is being used. This would be limited to a reference to an
idfield other than the root ID:$.id(or justidif not referencing a nested object).