Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support JSON columns in Postgres #175

Merged
merged 5 commits into from
Feb 17, 2021
Merged

support JSON columns in Postgres #175

merged 5 commits into from
Feb 17, 2021

Conversation

czue
Copy link
Member

@czue czue commented Feb 17, 2021

This adds support for Postgres JSON column types. This is particularly useful if you want to use the DET to generate a "data lake" by exporting the entire contents of e.g. the "form" property.

I was shocked how easy this was. Only one little quirk to chase down with type compatibility.

@czue czue requested a review from snopoke February 17, 2021 13:15
Copy link
Contributor

@snopoke snopoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that this only works if you explicitly specify the data type in the query file.

@czue
Copy link
Member Author

czue commented Feb 17, 2021

Confirm that this only works if you explicitly specify the data type in the query file.

Correct. Was going to mention that in docs. I guess we could add a command-line flag to do this automatically or something, but guessing explicit is fine for now?

Let me know if you think it's worth adding a test that it doesn't change behavior without the type

@snopoke
Copy link
Contributor

snopoke commented Feb 17, 2021

Confirm that this only works if you explicitly specify the data type in the query file.

Correct. Was going to mention that in docs. I guess we could add a command-line flag to do this automatically or something, but guessing explicit is fine for now?

Yes, I think this should be explicit rather than creating JSON columns for incorrect query files.

@snopoke
Copy link
Contributor

snopoke commented Feb 17, 2021

Let me know if you think it's worth adding a test that it doesn't change behavior without the type

Don't think it's necessary

@czue czue merged commit 9b9cd50 into master Feb 17, 2021
@czue czue deleted the cz/json-columns branch February 17, 2021 14:06
@proteusvacuum
Copy link
Contributor

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants