Set mssql nvarchar columns to fixed length to allow indexing #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proteusvacuum
force-pushed
the
fr/mssql-nvarchar
branch
from
c279a50 to
35e45a6
Compare
proteusvacuum
commented
Nov 26, 2020
proteusvacuum
force-pushed
the
fr/mssql-nvarchar
branch
from
35e45a6 to
9b94053
Compare
proteusvacuum
force-pushed
the
fr/mssql-nvarchar
branch
from
9b94053 to
42c844c
Compare
kaapstorm
approved these changes
Nov 27, 2020
snopoke
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had issues where columns are getting created in mssql that can't be indexed because the length is not getting set correctly.
https://dimagi-dev.atlassian.net/browse/SC-988?focusedCommentId=100916&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-100916
This change sets a max length, but then overrides this if any data is bigger than the 900 byte maximum. These resized columns will no longer be able to be indexed, but having indices on large columns seems funny anyway.