Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for module paths to require-import-fragment #2181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for module paths to require-import-fragment #2181

wants to merge 2 commits into from
+25 −1

Conversation

jksmithing
Copy link

@jksmithing jksmithing commented Feb 15, 2024 •
edited
Loading

Description

This change modifies the require-import-fragment rule to support module paths.

Fixes #2180

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added a new test case to packages/plugin/__tests__/require-import-fragment.spec.ts.

Test Environment:

  • OS: macOS 14.2.1
  • @graphql-eslint/...: 4.0.0-alpha.0
  • NodeJS: 18.12.1

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2024

⚠️ No Changeset found

Latest commit: d33edb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frimmy
Copy link

frimmy commented Apr 9, 2024

@jksmithing niiice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require-import fragment does not support module paths
2 participants
@jksmithing @frimmy