Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigContext mapping to TenantGroup #2229

Closed
sdktr opened this issue Jul 10, 2018 · 1 comment
Closed

Add ConfigContext mapping to TenantGroup #2229

sdktr opened this issue Jul 10, 2018 · 1 comment
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@sdktr
Copy link
Contributor

sdktr commented Jul 10, 2018 •
edited by jeremystretch
Loading

Issue type

[X] Feature request
[ ] Bug report
[ ] Documentation
[ ] Housekeeping

Environment

  • Python version: 3.6
  • NetBox version: 2.4-develop

Description

The new ConfigContext model is an absolute killer feature. We've a whole set of ideas on how we can leverage this and have to be careful not to try and force data in there for which it's not suited (yet).

The number one on my wishlist is a place to store the most generic 'fallback' settings. In our case that maps to the Netbox 'TenantGroup' model. If no tenant (customer), site (location) specific settings are in place that's were I'd like to fallback to.

Could TenantGroup be added to the models to which a ConfigContext can be mapped? As least 'weighted' option in case of a tie in defined weights?
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application beta labels Jul 18, 2018
jeremystretch added a commit that referenced this issue Jul 27, 2018
@jeremystretch
Closes #2229: Allow mapping of ConfigContexts to tenant groups
a1e8397
@sdktr
Copy link
Contributor Author

sdktr commented Aug 1, 2018

works like a charm, thanks a lot @jeremystretch !

@jeremystretch jeremystretch mentioned this issue Aug 6, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremystretch @sdktr