This repository has been archived by the owner on Sep 27, 2020. It is now read-only.
NATIVE-437: Rename StatusBar #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
a-kud,
lulo4907,
maxammann,
NKlug,
michael-markl and
SimonVortkamp
as code owners
|
I checked on an iphone with latest version. The bug is gone :) |
maxammann
approved these changes
Apr 29, 2020
michael-markl
approved these changes
May 15, 2020
This was referenced Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the bug described in the issue: https://issues.integreat-app.de/browse/NATIVE-437. Probably this was fixed as described in this comment facebook/react-native#26619 (comment) with the upgrade on ReactNative 0.61.5. So I just renamed
AndroidStatusBartoStatusBarsince it's not android exclusive (see: https://reactnative.dev/docs/statusbar). Don't know why git didn't get that.If the behaviour is different for you and you can reproduce it let me know.