Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-12-18] Add language selection box to statistics #3133

Closed
Tracked by #1097
JoeyStk opened this issue Oct 12, 2024 · 4 comments · Fixed by #3170
Closed
Tracked by #1097

[2024-12-18] Add language selection box to statistics #3133

JoeyStk opened this issue Oct 12, 2024 · 4 comments · Fixed by #3170
Assignees
Labels
deadline Needs to be fixed in the given time effort: medium Should be doable in <12h feature New feature or request prio: high Needs to be resolved ASAP. tested Was successfully tested on cms-test
Milestone

Comments

@JoeyStk
Copy link
Contributor

JoeyStk commented Oct 12, 2024

Motivation

For the new statistics page we want an universal language selection box for both sections.

Proposed Solution

Therefore add a box for language selection and bind it to the already existing language selection provided by chart.js.

Alternatives

None

User Story

As a user of the CMS/user of the statistics I want to have an universal language selection so that I don't get confused between the two sections

Additional Context

This is part of our meta issue #1097

Design Requirements

Design proposal (v3):
https://www.figma.com/file/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1179-830

@JoeyStk JoeyStk added feature New feature or request deadline Needs to be fixed in the given time labels Oct 12, 2024
@JoeyStk JoeyStk added this to the 24Q4 milestone Oct 21, 2024
@JoeyStk JoeyStk added prio: high Needs to be resolved ASAP. effort: medium Should be doable in <12h labels Oct 22, 2024
@charludo charludo self-assigned this Oct 30, 2024
@charludo charludo linked a pull request Nov 4, 2024 that will close this issue
@juliankehne
Copy link

Tagging @osmers & @nikolahoff I believe these are topics for you
I just testing this and have some feedback, some UX things and in I didn't find what the expected behaviour should be.

  1. Changing the time range for the statistic resets the selection of languages
    Example: A user deselects languages, then decides to change the time range afterwards, all languages get selected again.

  2. With a lot of languages it becomes tedious to select only a few languages, as you need to deselect every language manually. (Paired with 1. I can imagine this would be quite annoying)

  3. The csv export always includes all languages. I was just wondering if the csv export should only include selected languages (the image/png export does this). I guess it also depends on how the csv is used afterwards.

  4. Inside the design document the deselected languages/statistic have a grey color icon instead of the color used to display it inside the graph. Currently in the cms it keeps the color when deselected.

Design:
2024-11-12 13_10_54-Window
In CMS:
2024-11-12 13_11_20-Window

@osmers
Copy link

osmers commented Nov 19, 2024

For 1. if we could fix it, that would be great - not urgent though in my opinion
For 2. we could simply add a "deselect all languages" checkbox/button?
For 3. I think we decided to always include all languages since it's easy to deleted languages in csv... it's also how it was before. If @nikolahoff says that it might be confusing we could change that and add it in an extra issue (not urgent imho though as it's the status quo)
For 4. I'm ok with either but we should probably follow the design :)

@juliankehne juliankehne added feature New feature or request prio: high Needs to be resolved ASAP. effort: medium Should be doable in <12h deadline Needs to be fixed in the given time tested Was successfully tested on cms-test and removed feature New feature or request prio: high Needs to be resolved ASAP. effort: medium Should be doable in <12h deadline Needs to be fixed in the given time labels Nov 25, 2024
@nikolahoff
Copy link

@juliankehne @osmers

  1. I agree
  2. a deselect all button would be great (will add in the design)
  3. I think the user only wants to see the languages that were selected, so I would prefer to export only the selected languages
  4. I asked Toni for the reason why the colours get grey. I'm not sure, as she did the Design.

@juliankehne
Copy link

@nikolahoff @osmers Created issues for 1, 2 & 3 (#3277 #3278 ##3279). Feel free to change them if needed

@nikolahoff As for the 4th point you can create an issue if its supposed to change or comment here if it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time effort: medium Should be doable in <12h feature New feature or request prio: high Needs to be resolved ASAP. tested Was successfully tested on cms-test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants