Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation for application endpoint #1816

Open
ztefanie opened this issue Dec 4, 2024 · 1 comment
Open

Input validation for application endpoint #1816

ztefanie opened this issue Dec 4, 2024 · 1 comment
Labels

Comments

@ztefanie
Copy link
Member

ztefanie commented Dec 4, 2024

Is your feature request related to a problem? Please describe.
Currently sending bad requests to the application endpoint and results in 500 server errors. This should not be the case and proper error handling should be added and proper error messages should be sent.

Describe the solution you'd like
Check all values of the application endpoint. What happens if they are set to "wrong" values. E.g. if setting `"givenInformationIsCorrectAndComplete" to false a 500 error is thrown or if an empty string is sent for any value (like forename) the server sends a 500 error.
Also if sending multiple query / muntations at once leads to an 500 error

Additional context
As this endpoint is open it should handle all kinds of requests that it gets properly.

@ztefanie
Copy link
Member Author

ztefanie commented Dec 4, 2024

I already moved this to next up, as I think when verein360 starts to use this endpoint, it would make sense we soonish validate input properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Next Up
Development

No branches or pull requests

1 participant