-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ability to save ed25519 in pem such that openssl understands it #851
base: main
Are you sure you want to change the base?
Conversation
Cool this will be really useful. Any notes for the MR itself? |
No specific notes, I can answer questions if you have any, I added a ED25519.md readfile file showing how to use this. |
What's preventing this from merging? |
I don't own the forge repo, the original owner has to review code and
decide if it's worth merging
…On Wed, Mar 24, 2021, 11:41 AM Roger Qiu ***@***.***> wrote:
What's preventing this from merging?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#851 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVIWPQY6TP5ZZYKKHAUIB3TFIBZLANCNFSM4YYEET7A>
.
|
…present to remove deprecated warning
tests/unit/ed25519.js
Outdated
@@ -45,7 +45,7 @@ var UTIL = require('../../lib/util'); | |||
ASSERT.ok(kp.publicKey); | |||
}); | |||
|
|||
it('should sign a SHA-256 digest of an UTF-8 message', function() { | |||
it('should sign a SHA-256 digestst of an UTF-8 message of an UTF-8 message', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here.
Hi, just a note that I forked this pull request into my own repository here : https://github.com/dugrema/forge/tree/ed25519 I added support for creating EdDsa25519 PEM Certificate Requests and signing them into certificates. I also added support to load and save PEM private keys (encrypted or not) that openssl can use. I'm using these EdDsa25519 private keys, certificates and CSR back and forth with python cryptography 3.1 (openssl 1.1.1f) on Ubuntu and some Raspberry Pis (32 and 64 bit). Been working ok for a week or so, I use them on RabbitMQ, nginx and MongoDB for authentication. So whenever this pull request goes through, I'd be interested in making my changes more robust. I really just hacked my way through making this work, I don't know much about ASN1. Right now this is just dev proof of concept stuff. |
No description provided.