Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to save ed25519 in pem such that openssl understands it #851

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

sigsegv0x0b
Copy link

No description provided.

@CMCDragonkai
Copy link

Cool this will be really useful. Any notes for the MR itself?

@sigsegv0x0b
Copy link
Author

Cool this will be really useful. Any notes for the MR itself?

No specific notes, I can answer questions if you have any, I added a ED25519.md readfile file showing how to use this.

@CMCDragonkai
Copy link

What's preventing this from merging?

@sigsegv0x0b
Copy link
Author

sigsegv0x0b commented Mar 24, 2021 via email

@@ -45,7 +45,7 @@ var UTIL = require('../../lib/util');
ASSERT.ok(kp.publicKey);
});

it('should sign a SHA-256 digest of an UTF-8 message', function() {
it('should sign a SHA-256 digestst of an UTF-8 message of an UTF-8 message', function() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here.

@dugrema
Copy link

dugrema commented Jan 19, 2022

Hi, just a note that I forked this pull request into my own repository here : https://github.com/dugrema/forge/tree/ed25519

I added support for creating EdDsa25519 PEM Certificate Requests and signing them into certificates. I also added support to load and save PEM private keys (encrypted or not) that openssl can use.

I'm using these EdDsa25519 private keys, certificates and CSR back and forth with python cryptography 3.1 (openssl 1.1.1f) on Ubuntu and some Raspberry Pis (32 and 64 bit). Been working ok for a week or so, I use them on RabbitMQ, nginx and MongoDB for authentication.

So whenever this pull request goes through, I'd be interested in making my changes more robust. I really just hacked my way through making this work, I don't know much about ASN1. Right now this is just dev proof of concept stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants