Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sodium-native entirely #37

Closed
dlongley opened this issue Dec 11, 2019 · 4 comments
Closed

Remove sodium-native entirely #37

dlongley opened this issue Dec 11, 2019 · 4 comments
Assignees

Comments

@dlongley
Copy link
Member

Apparently, there's no way for npm to create reproducible builds using package lock files and no optional dependencies, so we should remove sodium-native from the optional dependencies and use the node-forge implementation for old versions of node.js.

@mattcollier
Copy link
Contributor

We're still working out the npm issues at this moment.

Whatever the case, it should be recognized what the performance implications of this are: https://github.com/digitalbazaar/crypto-bench

js ed25519 sign ~200 ops/sec vs sodium-native 4,787 ops/sec.

@mattcollier
Copy link
Contributor

Using a version of npm that respects the --no-optional parameter address the immediate issue: npm/cli#264. The root of the issue was using an out of date docker node 12 alpine image with a version of npm prior to 6.12 which ships with node 12.13.1

@dmitrizagidulin
Copy link
Contributor

@mattcollier Does that mean we should close this issue, or..?

@mattcollier
Copy link
Contributor

I believe it can be closed but @dlongley submitted the issue, so I think we should hear from him on the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants