Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async/promise versions of fs.exists fs.read etc. #4

Open
dlongley opened this issue Jul 16, 2021 · 0 comments
Open

Use async/promise versions of fs.exists fs.read etc. #4

dlongley opened this issue Jul 16, 2021 · 0 comments

Comments

@dlongley
Copy link
Member

Ideally, _applyConfig would be an async function and this would use await on the promise version of fs.exists. Seeing as the original version was still using blocking IO, I wouldn't hold up the PR for this. I'll create an issue out of this comment.

Originally posted by @dlongley in #3 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlongley