Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure tags with same URI are the same #141

Merged
merged 11 commits into from
Aug 10, 2021
Merged

fix: make sure tags with same URI are the same #141

merged 11 commits into from
Aug 10, 2021

Conversation

jonasbovyn
Copy link
Contributor

fixes #139

woutermont
woutermont suggested changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@woutermont woutermont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a good solution is found, don't forget to add tests.

packages/semcom-sdk/lib/component/services/register-component.service.ts Outdated Show resolved Hide resolved
woutermont
woutermont reviewed Aug 2, 2021
View reviewed changes
Copy link
Contributor

@woutermont woutermont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbelVandenBriel, code LGTM, so check if you understand it as well and take a good look at the tests please. Thx!

@woutermont
Copy link
Contributor

Okay, so here we have this segfault problem, which according to @jonasbovyn might be because we're mocking eval ... @AbelVandenBriel can you look into that when you have time?

@woutermont woutermont merged commit 23ae680 into develop Aug 10, 2021
@woutermont woutermont deleted the fix/define-tag-error branch August 10, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbelVandenBriel AbelVandenBriel AbelVandenBriel left review comments

@woutermont woutermont woutermont approved these changes

@arnevandoorslaer arnevandoorslaer Awaiting requested review from arnevandoorslaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasbovyn @woutermont @AbelVandenBriel