Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make select element compatible with form element component #171

Merged
merged 5 commits into from
Jun 20, 2022
Merged

feat: make select element compatible with form element component #171

merged 5 commits into from
Jun 20, 2022

Conversation

Giacomo-Papaluca
Copy link
Contributor

No description provided.

@lem-onade lem-onade changed the title Feat: make select element compatible with form element component feat: make select element compatible with form element component Jun 20, 2022
lem-onade
lem-onade approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@lem-onade lem-onade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine, thanks!

added a default value for the select in a60d7d8 to verify it works correctly

@lem-onade lem-onade enabled auto-merge (squash) June 20, 2022 09:58
@lem-onade lem-onade merged commit 05d2b67 into develop Jun 20, 2022
@lem-onade lem-onade deleted the feat/make-select-element-compatible-with-form-element branch June 20, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lem-onade lem-onade lem-onade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giacomo-Papaluca @lem-onade