Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dont show card header border #106

Merged
merged 4 commits into from
Nov 26, 2021

Conversation

arnevandoorslaer
Copy link

No description provided.

@arnevandoorslaer arnevandoorslaer self-assigned this Nov 24, 2021
@arnevandoorslaer arnevandoorslaer marked this pull request as draft November 24, 2021 15:54
@arnevandoorslaer arnevandoorslaer changed the title feat: dont shot card header border feat: dont show card header border Nov 24, 2021
@arnevandoorslaer arnevandoorslaer marked this pull request as ready for review November 24, 2021 16:26
@woutermont
Copy link
Contributor

Still seeing the border
image

@woutermont
Copy link
Contributor

Ah, but you meant only within the card component ... why would we always hide the border there? Wouldn't it be better to hide it conditionally on parts/slots being present or not?

@woutermont woutermont merged commit 9d4b23b into develop Nov 26, 2021
@woutermont woutermont deleted the feat/dont-show-card-header-border branch November 26, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants