fix(autocomplete): Fix unused defaultValue prop #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsebrech
approved these changes
Sep 3, 2021
jsebrech
reviewed
Sep 3, 2021
|
This isn't the right way to fix the underlying problem. See the discussion on #244. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaultValue prop was not being used, which resulted in it not
working.
Closes #244
PR Checklist
This PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
defaultValue prop on the Autocomplete component does nothing.
Issue Number: #244
What is the new behavior?
defaultValue prop on the Autocomplete component iis taken into account.
Does this PR introduce a breaking change?
Other information
Resolved issues
Fixes: #244