From 3c933597f57295ea387d9c22392fb8c2e27282c5 Mon Sep 17 00:00:00 2001
From: Julia Damerow <julia.damerow@googlemail.com>
Date: Tue, 14 May 2019 14:00:54 -0700
Subject: [PATCH] [bugfix] fixed Staff role issue and Maven variable name issue

---
 .../main/webapp/WEB-INF/views/staff/images/imagelist.jsp    | 6 +++---
 vspace/src/main/webapp/WEB-INF/views/staff/users/list.jsp   | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/vspace/src/main/webapp/WEB-INF/views/staff/images/imagelist.jsp b/vspace/src/main/webapp/WEB-INF/views/staff/images/imagelist.jsp
index f08aabb22..5bf74523b 100644
--- a/vspace/src/main/webapp/WEB-INF/views/staff/images/imagelist.jsp
+++ b/vspace/src/main/webapp/WEB-INF/views/staff/images/imagelist.jsp
@@ -103,9 +103,9 @@ $( document ).ready(function() {
                                     <option>Assign a tag</option>
                                     <c:forEach
                                         items="${imageCategories}"
-                                        var="tag">
-                                        <option value="${tag}"><spring:eval
-                                                expression="@configFile.getProperty('image_category_' + tag)" /></option>
+                                        var="catTag">
+                                        <option value="${catTag}"><spring:eval
+                                                expression="@configFile.getProperty('image_category_' + catTag)" /></option>
                                     </c:forEach>
                                 </select>
                             </form></td>
diff --git a/vspace/src/main/webapp/WEB-INF/views/staff/users/list.jsp b/vspace/src/main/webapp/WEB-INF/views/staff/users/list.jsp
index 76f1eed12..8263bfda7 100644
--- a/vspace/src/main/webapp/WEB-INF/views/staff/users/list.jsp
+++ b/vspace/src/main/webapp/WEB-INF/views/staff/users/list.jsp
@@ -35,13 +35,13 @@
             </c:if>
             
             <c:if test="${not fn:contains(user.roles, 'STAFF')}">
-		        <c:url value="/staff/user/${user.username}/role/add?roles=STAFF" var="url"/>
+		        <c:url value="/staff/user/${user.username}/role/add?roles=ROLE_STAFF" var="url"/>
 	            <form:form action="${url}" method="POST">
 	            <button style="padding:0px" class="btn btn-link"><span data-feather="user"></span> Make Staff</button>
 	            </form:form>
 	        </c:if>
             <c:if test="${fn:contains(user.roles, 'STAFF')}">
-	            <c:url value="/staff/user/${user.username}/role/remove?roles=STAFF" var="url"/>
+	            <c:url value="/staff/user/${user.username}/role/remove?roles=ROLE_STAFF" var="url"/>
 		        <form:form action="${url}" method="POST">
 	            <button style="padding:0px" class="btn btn-link"><span data-feather="user"></span> Remove Staff Role</button>
 	            </form:form>