Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/cite 223 - DOI field should be shown on citation pages #23

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Story/cite 223 - DOI field should be shown on citation pages #23

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7460352
[CITE-223] Changed doi to DOI as per JSON
PradnyaC11 Jul 25, 2024
f2a9fca
[CITE-223] Added JSONProperty to DOI & ISSN
PradnyaC11 Jul 26, 2024
dd03c11
[CITE-223] Addressed PR comments
PradnyaC11 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions spring-social-zotero/src/main/java/org/springframework/social/zotero/api/Data.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.util.List;

import com.fasterxml.jackson.annotation.JsonFilter;
import com.fasterxml.jackson.annotation.JsonProperty;

@JsonFilter("dataFilter")
public class Data {
Expand Down Expand Up @@ -35,7 +36,9 @@ public class Data {
private String seriesText;
private String journalAbbreviation;
private String language;
private String doi;
@JsonProperty("DOI")
private String DOI;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this is capitalized? It shouldn't be.

@JsonProperty("ISSN")
private String issn;
private String shortTitle;
private String archive;
Expand Down Expand Up @@ -216,11 +219,11 @@ public String getLanguage() {
public void setLanguage(String language) {
this.language = language;
}
public String getDoi() {
return doi;
public String getDOI() {
return DOI;
}
public void setDoi(String doi) {
this.doi = doi;
public void setDOI(String dOI) {
DOI = dOI;
}
public String getIssn() {
return issn;
Expand Down