Skip to content

Commit

Permalink
fix: remove 64bit builds to fix Galaxy S7 issue with Android v7 (#122)
Browse files Browse the repository at this point in the history
* fix: remove 64bit builds to fix Galaxy S7 issue with Android v7

See facebook/react-native#24261

* fix: Add ABI filter to filter our 64bit build
  • Loading branch information
gmaclennan authored May 10, 2019
1 parent 3c005a9 commit c163efc
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ android {
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"

ndk {
abiFilters "armeabi-v7a", "x86"
}
// Detox integration
// testBuildType System.getProperty('testBuildType', 'debug') //this will later be used to control the test apk build type
// missingDimensionStrategy "minReactNative", "minReactNative46" //read note
Expand All @@ -125,7 +127,7 @@ android {
reset()
enable enableSeparateBuildPerCPUArchitecture
universalApk false // If true, also generate a universal APK
include "armeabi-v7a", "x86", "arm64-v8a"
include "armeabi-v7a", "x86"
}
}
signingConfigs {
Expand Down Expand Up @@ -186,7 +188,7 @@ android {
variant.outputs.each { output ->
// For each separate APK per architecture, set a unique version code as described here:
// http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
def versionCodes = ["armeabi-v7a":1, "x86":2, "arm64-v8a": 3]
def versionCodes = ["armeabi-v7a":1, "x86":2]
def abi = output.getFilter(OutputFile.ABI)
if (abi != null) { // null for the universal-debug, universal-release variants
output.versionCodeOverride =
Expand Down

0 comments on commit c163efc

Please sign in to comment.