-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging not working in newest Safari #28
Comments
Hey @rsalzer It seems that safari is not re-rendering / re-calculating the layers with the new clip. I could fix the problem by setting the clip to "unset", force a re-render and then set the new clip. In the ...
if (this._leftLayer) {
const leftContainer = this._leftLayer.getContainer()
leftContainer.style.clip = 'unset'
leftContainer.offsetWidth; // forces re-calculation
leftContainer.style.clip = clipLeft
}
if (this._rightLayer) {
const rightContainer = this._rightLayer.getContainer()
rightContainer.style.clip = 'unset'
rightContainer.offsetWidth; // forces re-calculation
rightContainer.style.clip = clipRight
} |
With your fix it updates, but there is new weird behaviour:
|
yeah, it's also a bit hacky. I think this plugin needs a few changes but it seems unmaintained. |
Dragging with one finger touch in iOS (both safari and chrome for iOS)doesn't work, either. |
fixed with clip-path instead of clip. |
Did you do a PR already? ;) |
Nope, because I only tested it on iOS 13.+ and Mac OS X, Not sure if this fix works properly on other devices. :P |
Do you have a working example? I used your js and it still does not seem to work in my Safari on mac. |
Did you found the way to fix it? I tried Aaron's js but its not work |
Unfortunately not :( |
Does anyone have a clue how to fix it? It would be a shame if we can not use the plugin in safari ... |
Two commits before ... it seemed to still work. |
In Safari 12.1.1 on the Mac dragging does not work anymore. You can reproduce it with the Live example.
The text was updated successfully, but these errors were encountered: