Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo for insert_scattering_quantity in diffraction_objects.py #173

Closed
yucongalicechen opened this issue Nov 14, 2024 · 2 comments
Closed

fix typo for insert_scattering_quantity in diffraction_objects.py #173

yucongalicechen opened this issue Nov 14, 2024 · 2 comments
Milestone
3.6.0rc release

Comments

@yucongalicechen
Copy link
Contributor

Problem

In this function we have
elif xtype.lower() in DQUANTITIES:
self.on_tth = [np.array(xarray), np.array(yarray)]

Proposed solution

Change self.on_tth to self.on_d.
Refer to #154 for previous progress.
@yucongalicechen yucongalicechen mentioned this issue Nov 14, 2024
Closed
@sbillinge sbillinge added this to the 3.5.1 release milestone Nov 15, 2024
@bobleesj bobleesj mentioned this issue Nov 27, 2024
Closed
59 tasks
@sbillinge
Copy link
Contributor

I think this is fixed by #193, but please confirm and we can close

@yucongalicechen
Copy link
Contributor Author

confirmed that this issue can be closed by #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0rc release
Development

No branches or pull requests
2 participants
@sbillinge @yucongalicechen