You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
help="the x-range over which to calculate NMF, can be multiple ranges (e.g. --xrange 5,10 12,15)",
)
Suggestion
Recommended by @sbillinge , instead of creating a separate nested function called tup, we shall use argparse to parse the input more gracefully. I am currently not so familiar with the argparse library at the moment. Once we are done with the cookiecutting release process, we can re-visit this problem.
The text was updated successfully, but these errors were encountered:
Potential area of improvement
As discussed in #3 (comment), the
tup
function below is used to parse a string of two integers separated by a comma.diffpy.nmf_mapping/diffpy/nmf_mapping/nmf_mapping/main.py
Lines 36 to 44 in 57eb972
tup
is used as an input to theparser.add_argument
function shown below:diffpy.nmf_mapping/diffpy/nmf_mapping/nmf_mapping/main.py
Lines 100 to 107 in 57eb972
Suggestion
Recommended by @sbillinge , instead of creating a separate nested function called
tup
, we shall useargparse
to parse the input more gracefully. I am currently not so familiar with theargparse
library at the moment. Once we are done with the cookiecutting release process, we can re-visit this problem.The text was updated successfully, but these errors were encountered: