Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse-WTP CSS integration #311

Merged
merged 4 commits into from
Oct 25, 2018
Merged

Eclipse-WTP CSS integration #311

merged 4 commits into from
Oct 25, 2018

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Oct 20, 2018

Integrated Eclipse-WTP CSS formatter to Maven and Gradle.
Please have a look at the Gradle sample for details.

@fvgh fvgh requested a review from nedtwigg October 20, 2018 12:33
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me. My only request is to add prettier support to CssExtension, but that's a feature request, not a bug with this, so I think it's fine to merge and release this as-is. My vote is either:

  • merge this as-is and create an issue "Add prettier to CssExtension", and anybody who wants to can add it later

or

  • add prettier and then merge

Your call @fvgh, do either as you wish, and I'll cut a release.

@fvgh fvgh merged commit 84276b5 into master Oct 25, 2018
@fvgh fvgh deleted the css_integration branch October 25, 2018 03:20
@fvgh
Copy link
Member Author

fvgh commented Oct 25, 2018

@nedtwigg Opened #312 .

@nedtwigg
Copy link
Member

Published in x.16.0

@fvgh fvgh mentioned this pull request Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants