Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage Maven local repository for p2 cache directory in Eclipse step #2238

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

kevinleturc
Copy link
Contributor

This PR brings support of the Maven local repository configuration to store the Equo P2 cache.

This tackles what was mentioned in this comment #1687 (comment). And more precisely the use case described in #1797.

I didn't bring such support for Gradle as I lack of knowledge of it.

@nedtwigg
Copy link
Member

Does this change the location of cached files by default? Or does the user need to opt-in? If they need to opt-in, is that documented anywhere? My preference is to just have good defaults, and I'm okay with improving the defaults.

@kevinleturc
Copy link
Contributor Author

kevinleturc commented Sep 2, 2024

Yes it changes the location of cached files for P2 and maven users, but not in a lot of user installation.
P2 stores its data under ${user.home}/.m2/repository/dev/equo/p2-data/ which is the default location for maven users.
The proposed improvement is to store P2 data in the configured local maven repository, which is:

  • the default location if not configured: ${user.home}/.m2/repository/dev/equo/p2-data/
  • the local repository referenced in the settings.xml file under /settings/localRepository element
  • the path given on mvn command line with -Dmaven.repo.local=/tmp/repository

The proposed change could also be seen as a fixed because as a maven user you expect downloaded data for build to be stored in the configured local repository.

Into which documentation may I add such change?

@nedtwigg
Copy link
Member

nedtwigg commented Sep 3, 2024

Roger. Thanks for explaining! No more docs needed.

@nedtwigg nedtwigg merged commit 9556c8d into diffplug:main Sep 23, 2024
16 checks passed
@kevinleturc kevinleturc deleted the feat-maven-plugin-p2-cache branch December 10, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants