Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE in eclipse formatter #116

Closed
cal101 opened this issue May 28, 2017 · 3 comments
Closed

NPE in eclipse formatter #116

cal101 opened this issue May 28, 2017 · 3 comments
Labels

Comments

@cal101
Copy link
Contributor

cal101 commented May 28, 2017

Hi Spotlessers!

I think the following NPE in the eclipse formatter bytes me:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=500443

As far as I can see spotless is using version 4.6.1 of eclipse formatter.
Are there any plans updating to 4.6.3 soon?

I updated the eclipse formatter of my spotless installation in the past.It was not nice to do ...
Did the selection of the correct combination of jars got more easy?

Keep on going with this great project,
Cal

@cal101
Copy link
Contributor Author

cal101 commented May 28, 2017

Looks like the major work of selecting the correct jars seems to be done already in goomph.

Bumping the version strings from 4.6.1 to 4.6.3 and executing:

./gradlew -b _ext/eclipse-jdt/build.gradle publish

Gave me "version not supported"

Guess I need GOOMPH 3.8.0-SNAPSHOT.

I normally use gradle but had to do some maven lately and like it's "mvn install" that install into
local maven repo (~/.m2).
Whats the equivalent of "mvn install" that installs into "mavenLocal()" for getting spotless to use my locally built goomph?

Later:
Found via build.gradle:
https://oss.sonatype.org/content/repositories/snapshots/com/diffplug/gradle/goomph/3.8.0-SNAPSHOT/

After failing to understand the p2maven stuff I went with "publishToMavenLocal".

The update to 4.6.3 indeed solves the NPE I saw.

@nedtwigg nedtwigg added the bug label May 28, 2017
@nedtwigg
Copy link
Member

Thanks for bringing this to our attention! I just published support for eclipse 4.6.3, here's how to use it:

plugins {
  id "com.diffplug.gradle.spotless" version "3.4.0"
}

spotless {
  java {
    eclipse('4.6.3').configFile('gradle/spotless.eclipseformat.xml')
  }
}

We'll make 4.6.3 the default eclipse formatter in the next spotless release, or maybe 4.7.0 if it's out by then.

@cal101
Copy link
Contributor Author

cal101 commented May 28, 2017

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants