Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing type alias order by for auto type #3744

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Fix missing type alias order by for auto type #3744

merged 3 commits into from
Aug 14, 2023

Conversation

Elrendio
Copy link
Contributor

Resolves #3736

What it does:

  • Adds type alias OrderBy pointing to Order and uses it as return type or .order_by(ordering)

weiznich
weiznich approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@weiznich weiznich added this pull request to the merge queue Aug 14, 2023
Merged via the queue into diesel-rs:master with commit c99ebda Aug 14, 2023
31 checks passed
@Elrendio Elrendio deleted the FIX-MissingTypeAliasOrderByForAutoType branch August 15, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiznich weiznich weiznich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing type alias OrderBy for dsl::auto_type
2 participants
@Elrendio @weiznich