CI: wrong hotfix version computed

[NiccoMlt]

Problem

Release job for hotfix 2.0.1 acutally computed a version 2.1.0:
https://github.com/diennea/carapaceproxy/actions/runs/10795758991

./mvnw release:clean release:prepare release:perform \
      -Dtag=v2.1.0 \
      -DreleaseVersion=2.1.0 \
      -DdevelopmentVersion=2.1.1-SNAPSHOT \
      -Darguments='-DskipTests=true'

Why it happened

The POM file on release/2.0 was on version 2.1.0-SNAPSHOT

carapaceproxy/pom.xml

Line 7 in 57f4482

<version>2.1.0-SNAPSHOT</version>

In the 'Compute versions and branch name' step, for hotfixes:

carapaceproxy/.github/workflows/release.yml

Lines 51 to 56 in 57f4482

	case $bump in
	hotfix)
	branch_name="$(git branch --show-current)"
	release_version="${major}.${minor}.${patch}"
	release_development_version="${major}.${minor}.$((patch + 1))-${qualifier}"
	;;

the code extracts the major, minor, and patch versions from the current POM version. For a hotfix, it uses these values directly for the release version.

The problem is that:

• The POM version is 2.1.0-SNAPSHOT
• The script extracts major=2, minor=1, patch=0
• It then sets the release_version to "2.1.0"
• The hotfix process assumes that the version in the release branch's POM is already incremented to the next minor version (2.1.0-SNAPSHOT in this case)
• It doesn't decrement the minor version or check if it's on a release branch with a different version number

For a proper hotfix, I think that:

• The release/2.0 branch should have had a POM version of 2.0.1-SNAPSHOT
• Then the hotfix release would correctly become 2.0.1