Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to java 21 #438

Closed
hamadodene opened this issue May 16, 2023 · 4 comments · Fixed by #474
Closed

Upgrade to java 21 #438

hamadodene opened this issue May 16, 2023 · 4 comments · Fixed by #474

Comments

@hamadodene
Copy link
Contributor

No description provided.

@NiccoMlt
Copy link
Contributor

We already can run on Java 21 (#470), I think we should jump directly from Java 17 to Java 21 as the compile version.

What do you think @hamadodene? If you agree, please update the issue title; if you don't let's discuss it 😄, maybe I'm missing some compatibility issue

@hamadodene
Copy link
Contributor Author

We can update the title and test Carapace on java 21 locally and the if there's any issue we can creare a dedicated one

@hamadodene hamadodene changed the title Upgrade to java 19 Upgrade to java 21 May 24, 2024
@NiccoMlt
Copy link
Contributor

Makes sense

Maybe we could just bump the Java version in the POM and keep a look on potential problems

@hamadodene
Copy link
Contributor Author

@NiccoMlt Yes ...Feel free to send a PR...We also need to run the tests in JAVA 21.

@NiccoMlt NiccoMlt linked a pull request May 24, 2024 that will close this issue
build: upgrade to java 21 #474
Merged
@NiccoMlt NiccoMlt mentioned this issue May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: upgrade to java 21 diennea/carapaceproxy
2 participants
@NiccoMlt @hamadodene