Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 - Enable HTTP/2, ALPN & NPN by default #181

Open
aluccaroni opened this issue Jan 14, 2020 · 4 comments · May be fixed by #490
Open

HTTP/2 - Enable HTTP/2, ALPN & NPN by default #181

aluccaroni opened this issue Jan 14, 2020 · 4 comments · May be fixed by #490
Labels
component/core enhancement New feature or request
Milestone

Comments

@aluccaroni
Copy link
Contributor

For performance reason enable by default HTTP/2, Application Layer Protocol Negotiation and Next Protocol Negotiation.

We should have all the building blocks (Netty, boringSSL) to do so

@aluccaroni aluccaroni added component/core enhancement New feature or request labels Jan 14, 2020
@hamadodene
Copy link
Contributor

hamadodene commented Nov 29, 2022

With the migration to reactor netty, it is possible to enable HTTP2 support on both the server and client sides.
See https://projectreactor.io/docs/netty/release/reference/index.html#_http2 for server side
See https://projectreactor.io/docs/netty/release/reference/index.html#_http2_2 for client side.

Two http2 modes can be enabled:

  1. H2 for http2 with ciphertext
  2. H2C for Http with plaintext.
    With H2 you will need to provide a certificate for text encryption.

In my opinion both H2 and H2C need to be supported client side and server side. The administrator will have to decide which one to enable.

I would expect a configuration like this for server side:

listener.1.protocol=HTTP11,H2
listener.1.sslcertificate=example.p12   //mandatory if H2 is configured
listener.1.sslpassword=example 

listener.2.protocol=HTTP11,H2C

For client side:

client.protocol=HTTP11,H2
client.sslcertificate=example.p12  //mandatory if H2 is configured
client.sslpassword=example
 

or

client.protocol=HTTP11,H2C
Note:
A listener can support HTTP11+H2 or HTTP11 + H2C.
But it can NOT support HTTP11+H2+H2C. Basically you cannot configure H2 and H2C on the same listener. We will have to manage this in such a way that it is not possible.

@hamadodene
Copy link
Contributor

I did some testing and based on what said here https://projectreactor.io/docs/netty/release/reference/index.html#_protocol_selection , it seems that in our case, on the listener we can support HTTP11+H2 or HTTP11 +H2C.
So it's not possible to support HTTP11+H2+H2C on the same listener.

Does it make sense to you too? @pv3nturi

@aluccaroni
Copy link
Contributor Author

@hamadodene it shouldn't be a problem since we have different listener for http and https (different port). I don't see a case where we need a listener with H2+H2C

@hamadodene
Copy link
Contributor

@aluccaroni I agree with you

This was referenced Feb 17, 2023
@pv3ntur1 pv3ntur1 added this to the v2.0.0 milestone Feb 20, 2023
@NiccoMlt NiccoMlt linked a pull request Oct 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants