AGP 7.3 compatibility support #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonlee
reviewed
Nov 5, 2022
| @Suppress("DEPRECATION") | ||
| val deredundancy = variant.project.tasks.register("remove${variant.name.capitalize()}RedundantResources", klassRemoveRedundantImages.java) { task -> | ||
| val deredundancy = variant.project.tasks.register("remove${variant.name.capitalize()}RedundantResources", RemoveRedundantImages::class.java) { task -> |
johnsonlee
reviewed
Nov 5, 2022
| @@ -28,9 +26,10 @@ class ResourceDeredundancyVariantProcessor : VariantProcessor { | |||
| override fun process(variant: BaseVariant) { | |||
| val project = variant.project | |||
| val results = CompressionResults() | |||
| val klassRemoveRedundantImages = if (project.isAapt2Enabled) RemoveRedundantFlatImages::class else RemoveRedundantImages::class | |||
| val mapSourceSetPaths = project.tasks.findByName(variant.getTaskName("map", "SourceSetPaths")) | |||
There was a problem hiding this comment.
最好用 TaskProvider 的 named API
johnsonlee
reviewed
Nov 5, 2022
| import com.didiglobal.booster.gradle.getTaskName | ||
| import com.didiglobal.booster.gradle.isAapt2Enabled | ||
| import com.didiglobal.booster.gradle.mergeResourcesTaskProvider | ||
| import com.didiglobal.booster.gradle.project | ||
| import com.didiglobal.booster.gradle.* |
johnsonlee
reviewed
Nov 5, 2022
Comment on lines
65
to
73
| private fun BaseVariant.cachedMap(): Map<String, String> { | ||
| return this.allArtifacts["SOURCE_SET_PATH_MAP"] | ||
| ?.flatMap(File::readLines) | ||
| ?.map { | ||
| it.split(" ") | ||
| }?.associate { | ||
| it[0] to it[1] | ||
| } ?: emptyMap() | ||
| } |
johnsonlee
reviewed
Nov 5, 2022
| ) | ||
|
|
||
| @Suppress("RemoveCurlyBracesFromTemplate", "FunctionName") | ||
| abstract class V72IntegrationTest(private val isLib: Boolean) { |
johnsonlee
reviewed
Nov 5, 2022
| projectDir.copyFromResource("src") | ||
| projectDir.newFile("gradle.properties").writeText("org.gradle.jvmargs=-Xmx4g -XX:MaxMetaspaceSize=2g") | ||
| assertEquals(7, AGP.revision.major) | ||
| assertEquals(2, AGP.revision.minor) |
johnsonlee
reviewed
Nov 5, 2022
Comment on lines
1
to
6
| # booster-android-gradle-v7_2 | ||
|
|
||
| This module is an implementation of [booster-android-gradle-api](../booster-android-gradle-api) for Android gradle plugin above 7.2 | ||
|
|
||
| 本模块是 [booster-android-gradle-api](../booster-android-gradle-api) 针对 Android gradle plugin 7.2 以上版本的实现。 | ||
|
|
johnsonlee
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.