You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of the re-write, we should look at all of the existing classes and see if they're all necessary and what can be improved.
There are several classes that have very similar names, which could be confusing;
DiceRoller and DiceRoll
RollResults and RollResult
etc.
Other things to consider are things like;
Currently the dice classes are responsible for rolling as well. It might be good to change this so that they just store the info (sides, qty, modifiers etc.), and have a new "Roll Engine" which does the rolling.
The grammar parser currently converts the notation directly to the various objects. It might be worthwhile creating an intermediary AST of plain objects. This could then allow us greater flexibility with passing them into the final output, and hopefully enabling us to do inline / recursive rolling (see Inline rolls #206).
This list is not exhaustive, but is a good starting point.
The text was updated successfully, but these errors were encountered:
As part of the re-write, we should look at all of the existing classes and see if they're all necessary and what can be improved.
There are several classes that have very similar names, which could be confusing;
DiceRoller
andDiceRoll
RollResults
andRollResult
Other things to consider are things like;
This list is not exhaustive, but is a good starting point.
The text was updated successfully, but these errors were encountered: