Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background from badges in header #4692

Merged
merged 1 commit into from
Jan 14, 2014

Conversation

svbergerem
Copy link
Member

@Flaburgan
Copy link
Member

Fix for #4689 I guess?

jhass added a commit that referenced this pull request Jan 14, 2014
@jhass jhass merged commit 80acf6b into diaspora:develop Jan 14, 2014
@jhass
Copy link
Member

jhass commented Jan 14, 2014

Thanks!

@svbergerem
Copy link
Member Author

@Flaburgan You are right! :)

@Flaburgan
Copy link
Member

I was wondering if the class .badge was inside bootstrap or created by us, because it would have been more coherent to simply remove the background from the .badge class (and verify this doesn't impact the mobile version)

@svbergerem
Copy link
Member Author

@Flaburgan: We just needed to remove the background from those two badges. Perhaps someone will need a badge with the default background in the header in some future commits.

@svbergerem svbergerem deleted the header-fix-badge-background branch January 14, 2014 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants