Fix services index view #3884
Merged
Fix services index view #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm the screenshots are swapped I guess? Could you update the changelog? And please stick with our workflow guide for any future contributions :) |
|
Screenshots are in correct sequence. The first one is before pic, the second one is after pic. When a user is connected to a service, there is no need to show another link for connecting to that service again. He can always disconnect and connect with another account if he wants to. Previous code tried to do that only. I will follow the workflow guide from next time :) |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Because,
:twitter == "twitter"givesfalse. I believed that this givestrue, did it change in recent versions of ruby?