Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5 #31

Closed
phadej opened this issue Dec 13, 2019 · 5 comments
Closed

Release 1.5 #31

phadej opened this issue Dec 13, 2019 · 5 comments

Comments

@phadej
Copy link
Contributor

phadej commented Dec 13, 2019

I see @byorgey updated and upload a lot of other diagrams packages, thanks for that! But this package seems to be forgotten?

@byorgey
Copy link
Member

byorgey commented Dec 13, 2019

Not forgotten! I have been having difficulty getting it to pass CI / build on all versions of GHC we want to support. I think it is pretty close though, I think we will just drop support for GHC 7.10 and it should be good to go.

@phadej
Copy link
Contributor Author

phadej commented Dec 13, 2019

One option is to merge tightly coupled diagrams-* packages into single repository, and use cabal v2-build for development (and haskell-ci for CI setup, instead of home brewed one; disclaimer I'm a maintainer of haskell-ci).

Single repository for all packages would improve the developer experience, that I can tell from servant and few other smaller "package universes" maintenance experience. It looks like most of diagrams is released in a lock-step, so separate repositories aren't really that separate.

@byorgey
Copy link
Member

byorgey commented Dec 13, 2019

diagrams-postscript-1.5 is now on Hackage.

I think you are 100% right about the benefits of moving to a monorepo. We just haven't bitten the bullet yet. Do you have any experience actually doing such a migration? I'm worried about how to maintain/migrate things like commit histories, github issues, etc.

@phadej
Copy link
Contributor Author

phadej commented Dec 13, 2019

git history can be maintained to some degree, using method described in https://saintgimp.org/2013/01/22/merging-two-git-repositories-into-one-repository-without-losing-file-history/

For GitHub side of things, I have no idea. I'd migrate them manually, given there are less than 10 open issues in most repositories (except diagrams-lib, which could be the target repository?). One can view that as an opportunity to go through all open issues. As for closed issues, they would still be there, even if you archive the repositories.

@phadej
Copy link
Contributor Author

phadej commented Jan 3, 2022

Looks like releases were done. Thanks.

@byorgey byorgey closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants