Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation data index is strange #7

Open
ghost opened this issue Nov 4, 2018 · 1 comment
Open

Validation data index is strange #7

ghost opened this issue Nov 4, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 4, 2018

File "model/src/dataset.py", line 32,
validation data X, Y is overlapped with train data X, Y.
I think it should be modified as follow.
X, Y = X[0 : int(0.2 * length) , :], Y[0 : int(0.2 * length), :]
=> X, Y = X[int(0.8 * length) : length, :], Y[int(0.8 * length) : length, :]

@greeness
Copy link

I agree that the validation data should not overlap with training data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant