Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C4GT] Asset: Add tests for InvalidAssetValue #372

Open
3 tasks
vatsa287 opened this issue Mar 12, 2024 · 13 comments · May be fixed by #529
Open
3 tasks

[C4GT] Asset: Add tests for InvalidAssetValue #372

vatsa287 opened this issue Mar 12, 2024 · 13 comments · May be fixed by #529
Assignees
Labels

Comments

@vatsa287
Copy link
Member

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-asset after adding it in the code.

Goals

  • Add tests for InvalidAssetValue for pallet/asset

Expected Outcome

  • Test should assert for InvalidAssetValue being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: check method asset_create_should_succeed which validates creation of asset.

Mockups / Wireframes

NA


Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts @vatsa287

Complexity

[Low]

Category

[Test]

Sub Category

[Beginner friendly]

@MjStar24
Copy link

hey @vatsa287 I have gone through the code base and I would like to work on this can you assign this to me

@Aloneking789
Copy link

The issue is still open i have made a pull request

@hardik-pratap-singh
Copy link
Contributor

Hello @amarts @vatsa287 !
Is the issue stills needs to be worked upon ?

If yes, I would love to work on it !
Kindly assign it to me if possible.

@VedantKhairnar
Copy link

Hello @hardik-pratap-singh
Are you currently open to contributing to the issue?
If yes, pls respond or directly raise the PR.
Thanks.

@hardik-pratap-singh
Copy link
Contributor

@VedantKhairnar Thanks for asking but I am busy with something else.

@JiyaGupta-cs
Copy link
Contributor

@vatsa287 is this open to work ?

@Zapper9982
Copy link

Hello @vatsa287 , I would like to work on this issue it seems inactive for a long time

@vatsa287
Copy link
Member Author

@Zapper9982 Looks like it has been taken up
#520

@sanika181 sanika181 linked a pull request Dec 5, 2024 that will close this issue
@ritankarsaha
Copy link
Contributor

@vatsa287 Can I take up this issue? This seems to have been inactive for a bit, Also I have worked on this issue and would like to propose a solution, the tests for the same have passed in my local env as well

Screenshot 2025-01-03 at 3 12 52 PM

@vatsa287
Copy link
Member Author

vatsa287 commented Jan 5, 2025

@ritankarsaha Sure. There is some other open PRs on this which had my review comments on it. Please refer them and feel free to open the PR.

@ritankarsaha
Copy link
Contributor

@ritankarsaha Sure. There is some other open PRs on this which had my review comments on it. Please refer them and feel free to open the PR.

@vatsa287 I had opened a PR a few days earlier, could you please say if the implementation is correct or do I need to make any more changes in the existing PR ?

@asmit27rai
Copy link

@vatsa287 I want to work on this issue. Please Assign This To Me.

@ritankarsaha
Copy link
Contributor

@vatsa287 I want to work on this issue. Please Assign This To Me.

I am at present working on this issue, but you could always help. Is there any better implementation you could think of?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants