-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C4GT] Asset: Add tests for InvalidAssetValue
#372
Comments
hey @vatsa287 I have gone through the code base and I would like to work on this can you assign this to me |
The issue is still open i have made a pull request |
Hello @hardik-pratap-singh |
@VedantKhairnar Thanks for asking but I am busy with something else. |
@vatsa287 is this open to work ? |
Hello @vatsa287 , I would like to work on this issue it seems inactive for a long time |
@Zapper9982 Looks like it has been taken up |
@vatsa287 Can I take up this issue? This seems to have been inactive for a bit, Also I have worked on this issue and would like to propose a solution, the tests for the same have passed in my local env as well ![]() |
@ritankarsaha Sure. There is some other open PRs on this which had my review comments on it. Please refer them and feel free to open the PR. |
@vatsa287 I had opened a PR a few days earlier, could you please say if the implementation is correct or do I need to make any more changes in the existing PR ? |
@vatsa287 I want to work on this issue. Please Assign This To Me. |
I am at present working on this issue, but you could always help. Is there any better implementation you could think of? |
Description
Subtask under : cord-network/community#7
New testcase can be tested under
cargo test -p pallet-asset
after adding it in the code.Goals
InvalidAssetValue
for pallet/assetExpected Outcome
InvalidAssetValue
being returned properly in all the possible calls.Acceptance Criteria
NA
Implementation Details
Look at other test cases, and add a test case for the same.
Ex: check method
asset_create_should_succeed
which validates creation of asset.Mockups / Wireframes
NA
Product Name
CORD
Organization Name
Dhiway
Domain
Blockchain
Tech Skills Needed
Rust
Mentor(s)
@amarts @vatsa287
Complexity
[Low]
Category
[Test]
Sub Category
[Beginner friendly]
The text was updated successfully, but these errors were encountered: