Add comments for buildFromReviseRatingProperties #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Bhagavath <[email protected]>
amarts
approved these changes
Mar 19, 2024
NiranjanAP
reviewed
Mar 20, 2024
| * | ||
| * @param rating - The rating revise entry to process. | ||
| * This includes the original rating's digest, signature, and other relevant details. | ||
| * @param chainSpace - The identifier of the blockchain space (as a URI) where the rating is being revoked. |
There was a problem hiding this comment.
Should we call it revoked? or revised?
There was a problem hiding this comment.
You are right. Revised is the correct word.
NiranjanAP
reviewed
Mar 20, 2024
| * This includes the original rating's digest, signature, and other relevant details. | ||
| * @param chainSpace - The identifier of the blockchain space (as a URI) where the rating is being revoked. | ||
| * This helps in pinpointing the exact location on the blockchain where the rating resides. | ||
| * @param authorUri - The Decentralized Identifier (DID) URI of the author who is revoking the rating. |
There was a problem hiding this comment.
same here - revoke or revise?
There was a problem hiding this comment.
You are right. Revised is the correct word.
amarts
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.